Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B #537: Make Virtual Router's instances re-contextable. #538

Merged
merged 1 commit into from
May 22, 2024
Merged

B #537: Make Virtual Router's instances re-contextable. #538

merged 1 commit into from
May 22, 2024

Conversation

sk4zuzu
Copy link
Collaborator

@sk4zuzu sk4zuzu commented Apr 3, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

This is a fix that enables Virtual Router instances to be updated/re-contexted.

References

#537

New or Affected Resource(s)

  • opennebula_virtual_router_instance

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@sk4zuzu sk4zuzu requested a review from treywelsh April 3, 2024 16:38
@frousselet frousselet linked an issue Apr 4, 2024 that may be closed by this pull request
Impossible to update context of Virtual Router instances #537
Closed
treywelsh
treywelsh reviewed Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@treywelsh treywelsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not know OpenNebula as well as you so feel free to correct me if I'm missing something in my comment

opennebula/resource_opennebula_virtual_machine.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

@github-actions github-actions bot closed this May 11, 2024
@sk4zuzu sk4zuzu reopened this May 17, 2024
@treywelsh treywelsh self-requested a review May 22, 2024 10:37
@treywelsh treywelsh merged commit 099209b into master May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treywelsh treywelsh treywelsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to update context of Virtual Router instances
2 participants
@sk4zuzu @treywelsh